Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New provider arukas #10862

Merged
merged 3 commits into from
Jan 9, 2017
Merged

New provider arukas #10862

merged 3 commits into from
Jan 9, 2017

Conversation

yamamoto-febc
Copy link
Contributor

This PR adds a provider for the Arukas.

Arukas is a Docker hosting service and is explained on the official website as follows.

Arukas is the simplest-to-use Container-as-a-service that makes it easy to deploy and manage apps at scale.

One can manage the container on arukas like this:

provider "arukas" {
    token = "[put_your_api_token]"
    secret = "[put_your_api_secret]"
}

resource "arukas_container" "foobar" {
    name = "terraform_for_arukas_test_foobar"
    image = "nginx:latest"
    instances = 1
    memory = 256
    ports = {
        protocol = "tcp"
        number = "80"
    }
    environments {
        key = "key1"
        value = "value1"
    }
}

The PR includes tests & documentation.

Test output :

TF_ACC=1 go test ./builtin/providers/arukas -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccArukasContainer_Basic
--- PASS: TestAccArukasContainer_Basic (80.82s)
=== RUN   TestAccArukasContainer_Update
--- PASS: TestAccArukasContainer_Update (164.25s)
=== RUN   TestAccArukasContainer_Minimum
--- PASS: TestAccArukasContainer_Minimum (79.97s)
=== RUN   TestAccArukasContainer_Import
--- PASS: TestAccArukasContainer_Import (69.71s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/arukas	394.961s

Looking forward to your feedback!

@stack72
Copy link
Contributor

stack72 commented Jan 3, 2017

Hi @yamamoto-febc

Thanks for the work here - this provider LGTM! There is a merge conflict on the vendor.json file (since we merged another provider) - please can you resolve that and then the code is mergeable.

I have requested an account on arukas.io - hopefully that will come through soon and I can run all the tests to make sure that they work as expected

Thanks for the work here

Paul

stack72
stack72 suggested changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict on vendor.json

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Jan 3, 2017
@yamamoto-febc
Copy link
Contributor Author

@stack72 Thanks for the review, and welcome to arukas.io!
I resolved conflicts so please review again.

Thanks!

@stack72
Copy link
Contributor

stack72 commented Jan 3, 2017

thanks for the changes @yamamoto-febc :) This LGTM! Just waiting to get my account on the provider for Terraform so we can run the acceptance tests

thanks

Paul

@stack72 stack72 self-assigned this Jan 3, 2017
@stack72 stack72 added enhancement and removed waiting-response An issue/pull request is waiting for a response from the community labels Jan 4, 2017
@yamamoto-febc
Copy link
Contributor Author

There was a merge conflict on the vendor.json file , so I resolved that.

@stack72
Copy link
Contributor

stack72 commented Jan 9, 2017

Hi @yamamoto-febc

Thanks for waiting here - this LGTM!

% make testacc TEST=./builtin/providers/arukas                                                                                               ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/01/09 17:08:13 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/arukas -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccArukasContainer_Basic
--- PASS: TestAccArukasContainer_Basic (88.30s)
=== RUN   TestAccArukasContainer_Update
--- PASS: TestAccArukasContainer_Update (98.31s)
=== RUN   TestAccArukasContainer_Minimum
--- PASS: TestAccArukasContainer_Minimum (74.70s)
=== RUN   TestAccArukasContainer_Import
--- PASS: TestAccArukasContainer_Import (28.64s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/arukas	289.960s

Paul

@stack72 stack72 merged commit 9176bd4 into hashicorp:master Jan 9, 2017
@jbardin
Copy link
Member

jbardin commented Jan 10, 2017

@stack72,

This broke the windows build.
Looks like the dependency gopkg.in/alecthomas/kingpin.v2 isn't compatible with windows.

@yamamoto-febc yamamoto-febc mentioned this pull request Jan 11, 2017
Closed
@yamamoto-febc
Copy link
Contributor Author

@stack72,
I found the cause of the broken build on Windows and I fixed it and created a pull request(#11140).
Please review and merge that:pray:

Yamamoto

catsby added a commit that referenced this pull request Jan 11, 2017
@catsby
Revert "New provider arukas (#10862)"
87bb691 
This reverts commit 9176bd4.
This provider includes a dependency that at time of writing requires a
*nix system, and will not build on Windows.
catsby added a commit that referenced this pull request Jan 11, 2017
@catsby
Merge pull request #11149 from hashicorp/revert-arukas
c629145 
Revert "New provider arukas (#10862)"
@yamamoto-febc yamamoto-febc mentioned this pull request Jan 12, 2017
Merged
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees

@stack72 stack72

Labels
enhancement new-provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamamoto-febc @stack72 @jbardin @jen20